dotnet/aspnetcore

Pass css class in `<ValidationSummary />` to the generated `<ul>`

Geschlossen

#43.860 geöffnet am 09.09.2022

Auf GitHub ansehenContributor Guide
 (5 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C# (10.653 Forks)batch import
area-blazorenhancementfeature-blazor-builtin-componentsgood first issuehelp wanted

Repository-Metriken

Stars
 (37.933 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 16T 9h) (258 gemergte PRs in 30 T)

Beschreibung

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

I am trying to pass additional css classes to the generated ul element. I am applying general formatting via the validation-errors css class, but I would like to be able to pass utility classes for spacing (i.e. pt-2 to add 8px of padding to the top of the validation summary).

Describe the solution you'd like

Update <ValidationSummary /> to pass unmatched attributes (via splatting) to the validation-errors element. In the case of class, it should append the passed in classes to the existing validation-errors class.

Additional context

For example:

<ValidationSummary class="pt-2" data-test="validation-errors" />

should result in:

<ul class="validation-errors pt-2"  data-test="validation-errors">
    <!-- Validation Errors -->
</ul>

Contributor Guide

Research-Richtung
The issue requests adding support for passing CSS classes and other attributes to the `<ul>` element in `<ValidationSummary>`. Examine the current implementation of `ValidationSummary` in the aspnetcore repository, likely in `src/Components/Web/src/Forms/ValidationSummary.cs`. The solution involves using `@attributes` splatting to pass unmatched attributes to the root element, and merging the `class` attribute with the existing `validation errors` class. Check the Blazor documentation for attribute splatting and refer to similar components like `ErrorBoundary` for pattern. Ensure backward compatibility and add tests.
Tech Stack
csharp
Domain
frontend
Issue Type
Funktion
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
Halber Tag
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
Frisch
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
Meist klar
Voraussetzungen
Basic knowledge of BlazorC# component creation
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
60