developit/workerize

Consider removing expose(), call() and kill() ?

Open

#26 geöffnet am 20. März 2018

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (113 Forks)batch import
enhancementhelp wanted

Repository-Metriken

Stars
 (4.299 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

	worker.expose = methodName => {
		worker[i] = function() {
			return worker.call(methodName, [].slice.call(arguments));
		};
	};

Instead methodName parameter should be used:

	worker.expose = methodName => {
		worker[methodName] = function() {
			return worker.call(methodName, [].slice.call(arguments));
		};
	};

Beside that I don't see why the call and expose methods are accessible from outside. (Don't assign to worker at all) The purpose of the kill method is also not clear for me.

Contributor Guide