desktop/desktop

Warn user of unmerged commits before deleting branch

Open

#4.214 geöffnet am 10. März 2018

Auf GitHub ansehen
 (3 Kommentare) (2 Reaktionen) (0 zugewiesene Personen)TypeScript (18.758 Stars) (9.945 Forks)batch import
enhancementhelp wantednot-planned

Beschreibung

Description

The user is not warned when deleting a branch which contains commits not yet merged into the master branch.

Version

  • GitHub Desktop: 1.1.0
  • Operating system: Windows 10 / Windows 7

Steps to Reproduce

  1. create new branch
  2. make one or more commits in the new branch
  3. delete the branch

Expected Behavior

A warning that not all commits have been merged into the master branch

Actual Behavior

A warning message is displayed stating that the operation cannot be undone. However, the message doesn't mention that there are commits in this branch which have not been merged into master branch

Additional Information

Logs

Contributor Guide

Tech Stack
typescriptreactelectronnodejs
Domain
desktop
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Basic Git knowledgeGitHub Desktop UITypeScript
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
70
Research-Richtung
The issue requests a warning when deleting a branch with unmerged commits. The implementation involves checking the branch's commits against the master branch before deletion. Relevant files likely include the branch deletion dialog (e.g., app/src/ui/dialogs/delete branch.tsx) and Git utilities (e.g., app/src/lib/git/branch.ts). The warning should display the number of unmerged commits and confirm the user's intent. No linked PRs or assignees exist, so the work is available.