danger/danger

Add ability to modify PR rather than just add comments

Offen

#825 geöffnet am 23.05.2017

 (4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Ruby (491 Forks)batch import
EnhancementHelp WantedYou Can Do This

Repository-Metriken

Stars
 (5.297 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 60T 8h) (5 gemergte PRs in 30 T)

Beschreibung

We use Danger for all internal PRs, not just from 3rd parties. One of the things that we do is scan the PR for ticket numbers referenced and automatically add a link to each of these tickets using the message() method. Unfortunately, this means that every PR generates at least one notification email due to the comment added by Danger.

Since GitHub aren't going to give us some kind of blacklist functionality, a better solution might be to give Danger the ability to append info to the end of the PR.

Either through using different methods, or by passing an optional flag, instead of adding a new comment with the contents, Danger could append it to the existing PR. Some text such as "Danger Report:" could be added, and anything below it is fair game for Danger to change (that way it can be modified when things change instead of just appending).

I'd happily look into the changes myself, but other than the 50 lines of if statements in our Dangerfile, I've never written a line of Ruby in my life.

Contributor Guide