cube-js/cube

Schema Compiler - Column names in Hebrew: support schema generation for non ASCII table names

Open

#5.174 geöffnet am 27. Aug. 2022

Auf GitHub ansehen
 (3 Kommentare) (2 Reaktionen) (0 zugewiesene Personen)Rust (1.965 Forks)batch import
help wanted

Repository-Metriken

Stars
 (19.563 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 5T 16h) (138 gemergte PRs in 30 T)

Beschreibung

Describe the bug When generating my cube with the schema compiler, column names in Hebrew letters are trimmed and a empty key dimension is generated.

To Reproduce Steps to reproduce the behavior:

  1. Generate a schema with the schema compiler in localhost:4000/playground with Hebrew column names.
  2. You'll notice that generated dimensions key's that suppose to have Hebrew letters are empty.
cube(`TableNameWithHebrewColumnName`, {
  sql: `SELECT * FROM "TableName"."TableNameWithHebrewColumnName"`,
  
  preAggregations: {
    // Pre-Aggregations definitions go here
    // Learn more here: https://cube.dev/docs/caching/pre-aggregations/getting-started  
  },
  
  joins: {
    
  },
  
  
  dimensions: {
    formNumber: {
      sql: `${CUBE}."Form_Number"`,
      type: `number`
    },
   
    : {
      sql: `${CUBE}.`,
      type: `string`,
    },
  },
  
  dataSource: `default`
});

Expected behavior To have an object with hebrew letters.

expected :  "גיל " : {
                       sql: `${CUBE}.גיל `,
                       type: `string`,
                  } 

Version: @cubejs-backend/schema-compiler : 0.30.45

Contributor Guide