cube-js/cube
Schema Compiler - Column names in Hebrew: support schema generation for non ASCII table names
Offen
#5.174 geöffnet am 27.08.2022
help wanted
Repository-Metriken
- Stars
- (19.563 Sterne)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
Describe the bug When generating my cube with the schema compiler, column names in Hebrew letters are trimmed and a empty key dimension is generated.
To Reproduce Steps to reproduce the behavior:
- Generate a schema with the schema compiler in localhost:4000/playground with Hebrew column names.
- You'll notice that generated dimensions key's that suppose to have Hebrew letters are empty.
cube(`TableNameWithHebrewColumnName`, {
sql: `SELECT * FROM "TableName"."TableNameWithHebrewColumnName"`,
preAggregations: {
// Pre-Aggregations definitions go here
// Learn more here: https://cube.dev/docs/caching/pre-aggregations/getting-started
},
joins: {
},
dimensions: {
formNumber: {
sql: `${CUBE}."Form_Number"`,
type: `number`
},
: {
sql: `${CUBE}.`,
type: `string`,
},
},
dataSource: `default`
});
Expected behavior To have an object with hebrew letters.
expected : "גיל " : {
sql: `${CUBE}.גיל `,
type: `string`,
}
Version: @cubejs-backend/schema-compiler : 0.30.45