corejavascript/typeahead.js

Travis Not running Browser tests

Open

#20 geöffnet am 16. Okt. 2015

Auf GitHub ansehen
 (5 Kommentare) (0 Reaktionen) (1 zugewiesene Person)JavaScript (956 Stars) (232 Forks)batch import
bughelp wanted

Beschreibung

Hi, of the 12 jobs running upon every Pull-request commit, none of the browser specific tests run!

Only the unit-test runs.

For example on #18, the tests ran, but only travis build 26.1 actually ran the test suite.

The others (browser based) had the following line in the output:

Not running any tests

which you can see for instance in travis build 26.2 and all the others in the travis build list for #18.

The line in test/ci https://github.com/corejavascript/typeahead.js/blob/master/test/ci#L5

elif [ "$TRAVIS_SECURE_ENV_VARS" == "true" -a "$TEST_SUITE" == "integration" ]; then

evaluates to

+'[' false == true -a integration == integration ']'

which must mean that "$TRAVIS_SECURE_ENV_VARS" is not set.

Who can help setting up the browser tests again?? I'd like to help but am in doubt about who has access to setting it up?

Contributor Guide

Tech Stack
javascript
Domain
devopstesting
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Travis CI configurationbash scriptingrepository admin access
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
30
Research-Richtung
Examine the test/ci script and the Travis CI configuration. The issue is that $TRAVIS SECURE ENV VARS is not set to true for pull requests from forks, causing the browser tests to be skipped. Check Travis CI documentation on secure environment variables and consider whether the repository requires admin intervention to set them. Look into alternative approaches that do not rely on secure vars.