chroma-core/chroma

[CLN] Break up test_api

Offen

#2.586 geöffnet am 28.07.2024

 (4 Kommentare) (0 Reaktionen) (1 zugewiesene Person)Rust (2.247 Forks)batch import
by-chromacleanupgood first issue

Repository-Metriken

Stars
 (27.958 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 1T 16h) (80 gemergte PRs in 30 T)

Beschreibung

test_api.py is a legacy of Chroma's launch, and provided some basic initial test coverage. We've continued to add to it as the project has evolved, and it's become a catch-all kitchen sink test file.

In practice a lot of the surface covered in test_api is better covered by our property tests. test_api.py should be broken up into separate files by API / object, and each object test should cover exceptional cases, rather than normal operation.

For example, we should save entropy in the property tests by not having them generate lists of IDs that are shorter than the lists of documents on a Collection.add call, but we should also be testing this path.

Contributor Guide