bumptech/glide

Annotation processor uses class name as package name causing conflicts

Open

#2.860 geöffnet am 1. Feb. 2018

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Java (6.176 Forks)batch import
bughelp wanted

Repository-Metriken

Stars
 (35.023 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 4T 10h) (11 gemergte PRs in 30 T)

Beschreibung

Glide Version: 4.x

Integration libraries: N/A

Device/Android Version: N/A

Issue details / Repro steps / Use case background:

https://github.com/bumptech/glide/blob/eff228fcafc2a3e6077d15d0f2a995edf46f1f56/annotation/compiler/src/main/java/com/bumptech/glide/annotation/compiler/AppModuleProcessor.java#L84

See https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/glidelibrary/ZreirxaqMu0/QGhfJKJoBAAJ

Related: https://github.com/bumptech/glide/issues/2512

Glide load line / GlideModule (if any) / list Adapter code (if any):

package com.example;
class MyApp {
    @GlideModule
    static class MyModule {
    }
}

will generate com.example.MyApp.GlideApp; where MyApp will be a package and this conflicts with the outer class from the app.

Contributor Guide