awslabs/benchmark-ai

[Executor] Dangling resources on failed kubectl apply

Offen

#943 geöffnet am 14.10.2019

 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (6 Forks)auto 404
buggood first issueservice:executor

Repository-Metriken

Stars
 (19 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

The executor creates the kubernetes resources by executing a kubectl apply against a generated kubernetes resource file. Sometimes, these files can contain multiple resource definitions (Jobs, Pods, Services, Roles, etc.). This means that, while the command itself can fail (exit with non-zero), some of the (valid) kuberenetes resources would still be created.

We should issue a kubectl delete in case there is a failure. To ensure we don't leave any dangling resources in case of any failure.

Contributor Guide