Repository-Metriken
- Stars
- (279 Stars)
- PR-Merge-Metriken
- (PR-Metriken ausstehend)
Beschreibung
Thanks for writing this fast histogram package. A task that we astronomers tend to do often and repeatedly :)
Coming back to the package itself, it seems to me that the return datatype of the histograms are doubles. Conceptually, the histogram is simply a count in that bin, and should be of an integral type. Is the return datatype chosen to be double to reflect the input array type? Or is that in keeping with the numpy convention?
Changing the histogram increment to be an integral type (i.e., the postfix ++ operator) might also lead to better performance. (There are some opportunity for performance improvements -- e.g., pointer operations, reduction of scope for variables, unrolled loops + separate counters)
Separately, any particular reason to perform a bitwise and (&) rather than the logical and (&&) here?