appsmithorg/appsmith

(JS-0458) Definitions for unused states detected

Open

#7.943 geöffnet am 29. Sept. 2021

Auf GitHub ansehen
 (20 Kommentare) (0 Reaktionen) (1 zugewiesene Person)TypeScript (39.454 Stars) (4.508 Forks)batch import
Good First IssueLow effortTask

Beschreibung

Description

You should avoid defining states that are not being used because unused states might affect while refactoring the codebase and introduces unnecessary operations by ReactJS. It is recommended to plan the behavior and operation of the component.

Occurrences

There are 9 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/appsmithorg/appsmith/issue/JS-0458/occurrences/

Contributor Guide

Tech Stack
typescriptreact
Domain
frontend
Issue Type
refactor
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
active
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Basic React knowledgeUnderstanding of component stateFamiliarity with code editing
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
70
Research-Richtung
Review the 9 occurrences listed in the DeepSource link (deepsource.io/gh/appsmithorg/appsmith/issue/JS 0458/occurrences/). Each occurrence points to a file and line number where an unused state definition is detected. For each case, verify that the state variable is indeed not used anywhere in the component or its children. If unused, remove the state definition and any associated setter calls. Ensure that the component still functions correctly by checking for any indirect usage. The repository is TypeScript based React, so look for useState calls in function components. The issue has an assignee, so coordinate if necessary.