apache/pinot

Introduce reason codes in server http requests to controller

Open

#12.055 geöffnet am 28. Nov. 2023

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Java (1.234 Forks)batch import
cleanupgood first issue

Repository-Metriken

Stars
 (4.937 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 6T 7h) (186 gemergte PRs in 30 T)

Beschreibung

pinot servers send HTTP requests to the controller for posting a completed realtime segment, posting an indication that realtime segments have stopped consuming, or that the consumer could never be created.

Currently there is a reason string that is included as an argument. This is error prone. A reason code makes it easier to incorporate code for appropriate action, given a particular reason.

The con side of a reason code is that it is a bit harder to evolve. We need to be careful writing code on the controller side, since servers may send unknown reason codes. As long as we follow some careful practices, introducing reason codes should get us to a better place.

Contributor Guide