apache/dubbo

Support set fixed rmi service port

Offen

#6.629 geöffnet am 20.08.2020

 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Java (26.453 Forks)batch import
help wantedtype/proposal

Repository-Metriken

Stars
 (41.524 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Rmi protocal will choose a random port as the service port. Sometimes we need to use a fixed port to ensure it is accessable from other service instance. Could add a parameter to support setting this port?

Here is my current code to set the service port.

org.apache.dubbo.rpc.protocol.rmi.RmiProtocol

  @Override
  protected <T> Runnable doExport(final T impl, Class<T> type, URL url) throws RpcException {
    RmiServiceExporter rmiServiceExporter = createExporter(impl, type, url, false);
    RmiServiceExporter genericServiceExporter =
        createExporter(impl, GenericService.class, url, true);

    // Here is the code to set the fixed service port.
    String servicePort = System.getProperty("dubbo.protocal.rmi.serviceport");
    if (servicePort != null && !servicePort.isEmpty()) {
      rmiServiceExporter.setServicePort(Integer.valueOf(servicePort));
    }

    return new Runnable() {
      @Override
      public void run() {
        try {
          rmiServiceExporter.destroy();
          genericServiceExporter.destroy();
        } catch (Throwable e) {
          logger.warn(e.getMessage(), e);
        }
      }
    };
  }

Contributor Guide