RFE: Send real client remote address in TACACS+ authentication packet · ansible/awx#1797

(1 Kommentar) (1 Reaktion) (0 zugewiesene Personen)Python (3.333 Forks)batch import

Hacktoberfestcomponent:apicomponent:authenticationgood first issuehelp wantedtype:enhancement

Repository-Metriken

Stars: (13.071 Stars)
PR-Merge-Metriken: (Durchschn. Merge 24T 6h) (30 gemergte PRs in 30 T)

Beschreibung

ISSUE TYPE

Feature Idea

COMPONENT NAME

SUMMARY

Currently the TACACS+ authentication backend

https://github.com/ansible/awx/blob/96370584062a15271abafab7fc557ac2879aa38c/awx/sso/backends.py#L225-L227

sends default value for client remote address

https://github.com/ansible/tacacs_plus/blob/526b5a29c5656bbd8644accca238d1e9303dc272/tacacs_plus/flags.py#L81

The function authenticate() in TACACSClient supports sending client remote address as parameter and should be used to correctly report client real address.

https://github.com/ansible/tacacs_plus/blob/9ba553f79efcc7b955001503d1953900ba6284a4/tacacs_plus/client.py#L158

ENVIRONMENT

AWX version: 1.0.5
AWX install method: openshift, minishift, docker on linux, docker for mac, boot2docker
Ansible version: N/A
Operating System: Any
Web Browser: Any

EXPECTED RESULTS

TACACS+ authentication packet will contain clients real remote address.

ACTUAL RESULTS

Client remote address is always set to python_device.

Contributor Guide

Research-Richtung: Ändern Sie den Aufruf der authenticate Methode in backends.py, um die entfernte Adresse des Clients an die Methode TACACSClient.authenticate() zu übergeben.
Tech Stack: python
Domain: backend
Issue Type: Funktion
Schwierigkeit: 2
Geschätzte Zeit: 1-3 Stunden
Aktivitätsstatus: Aktiv
Klarheit: Klar
Voraussetzungen: Python
Einsteigerfreundlichkeit: 70