angular-ui/ui-grid
Auf GitHub ansehen[selection] - event rowSelectionChanged - pass GridCol along with GridRow
Open
#4.534 geöffnet am 16. Okt. 2015
breakinghelp wantedtype: enhancement
Repository-Metriken
- Stars
- (5.395 Stars)
- PR-Merge-Metriken
- (Keine gemergten PRs in 30 T)
Beschreibung
currently event rowSelectionChanged has the following signature:
on.rowSelectionChanged($scope, function (row, event) { ... })
I have a use case when I'd also find useful information about column being clicked.
Detailed scenario:
Clicking on the row has an event associated (ex: redirects to another state). However, the very last column of each row is a custom column that allows deleting of that row. Currently clicking on the delete button in the given row will also trigger rowSelectionChanged event, which is not desired just for that column.
Given that I had information about GridCol in this event, I could write something like:
on.rowSelectionChanged($scope, function(row, col, event) {
if (col.name != 'delete') {
$state.go('superState');
}
});
This would be a breaking change since it would change the signature of the event. If I'm given a green light, I'll submit a PR.