andywer/react-usestyles

Allow eager styles preparation

Offen

#1 geöffnet am 11.11.2018

 (2 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (2 Forks)github user discovery
enhancementhelp wanted

Repository-Metriken

Stars
 (86 Sterne)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

There are some opt-in options available to improve the performance, but there is one thing they cannot improve:

Every styles object has to be prepared initially and that happens each component mount. This preparation primarily means separation between static and dynamic style rules/declarations (function values).

Especially for components that get instantiated a lot that might have a serious performance impact.

Possible solution

Could pass a reference to the component to useStyles(), so the styles can be prepared only once for each component instead of once for each component instance.

import { useStyles } from "@andywer/style-hook"
import React from "react"

function Button () {
  const classNames = useStyles({
    default: {
      background: theme => props.background || theme.button.background.default
      // ...
    }
  }, Button, [props.background])
  return // ...
}

Additional benefit:

If we have the component reference, we have access to the component's name. Could use that for a better development / debugging experience (i.e. put component name on style tags).

Can also stop JSON.stringify()-ing the styles for deduplication when having a component reference. Will improve the overall performance even more!

Contributor Guide