alexcasalboni/ssm-cache-python

Improve "internal" consistency for individual params of a group

Offen

#16 geöffnet am 28.02.2018

 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (20 Forks)github user discovery
enhancementhelp wantedquestion

Repository-Metriken

Stars
 (209 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 9T 9h) (3 gemergte PRs in 30 T)

Beschreibung

_max_age and _last_refresh_time are not currently "shared" between a SSMParameterGroup and its SSMParameter objects.

While #14 has fixed the refreshing bug due to this inconsistency, we could somehow keep the internal Refreshable fields in sync between a group and its parameters to avoid more problems in the future. The current solution always delegates _should_refresh to the group.

Contributor Guide