akveo/ngx-admin

Support automatic theme detection from OS using prefers-color-scheme

Open

#5.542 geöffnet am 17. Okt. 2019

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (7.916 Forks)batch import
enhancementhelp wanted

Repository-Metriken

Stars
 (24.990 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

Issue type

I'm submitting a ... (check one with "x")

  • bug report
  • feature request
  • question about the decisions made in the repository

Issue description

Current behavior:

The default theme loads automatically, despite user OS preferences.

Expected behavior:

By using prefers-color-scheme media query, it would be possible to detect the user OS theme. For example, if my Windows theme is dark, the dark theme of ngx-admin should be loaded. If my Windows theme is light, then the light theme of ngx-admin should be loaded.

This is demo'ed here: https://davidwalsh.name/demo/prefers-color-scheme.php It already has decent browser support: https://caniuse.com/#search=prefers-color-scheme

Steps to reproduce:

Related code:

Other information:

This thread is related: https://github.com/angular/components/issues/16905

npm, node, OS, Browser OS: Windows 10 Browser: Chrome 77

Angular, Nebular

Contributor Guide