airbnb/react-sketchapp

Introduce `Page.Container` component

Open

#342 geöffnet am 30. Mai 2018

Auf GitHub ansehen
 (2 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (14.970 Stars) (900 Forks)batch import
enhancementgood first issuehelp wanted

Beschreibung

Right now the Page component acts a flex container, allowing to render Artboard's and SymbolMaster's in either a column or a row.

I'd like however to have unlimited flexibility rendering Pages by composing Flex components. By having some sort of arbitrary Flex container, I could layout items on a Page in complex grids if necessary.

This would require us introducing a new Component that can be utilized to compute Yoga layout, but doesn't actually result in any backed rendering.

@mathieudutour - I know this goes against some of your comments in #291, but I'm not sure how else to achieve this.

note: it doesn't need to be called Flex.

Contributor Guide

Tech Stack
reacttypescript
Domain
frontenddesign
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-2 days
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
mostly clear
Voraussetzungen
ReactTypeScriptreact sketchapp API
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
40
Research-Richtung
Examine the existing Page component in react sketchapp to understand its current flex container behavior. Review the discussion in issue #291 about layout flexibility, especially comments from @mathieudutour. The goal is to create a new container component (e.g., Flex) that computes Yoga layout without rendering anything. Look at the Yoga layout integration in the codebase, likely in the yoga layout package, and consider naming and API design.