abetlen/llama-cpp-python

suppress_stdout_stderr failing in notebooks

Geschlossen

#872 geöffnet am 05.11.2023

 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)Python (1.441 Forks)batch import
bughelp wanted

Repository-Metriken

Stars
 (10.558 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 1T 5h) (68 gemergte PRs in 30 T)

Beschreibung

Expected Behavior

Loading a model with verbose=False should not print things.

Current Behavior

verbose=False has no effect in notebooks (I tested with VS Code notebooks, but I think it is ipykernel related)

Steps to Reproduce

Just load a model with verbose=False and observe output in a notebook environment.

How to fix

The patch given in the ipykernel issue below fixes the issue for me (but requires me to do my own override of stdout and stderr since the patch also causes suppress_stdout_stderr to crash as currently written). A real fix might involve integrating this into suppress_stdout_stderr directly.

https://github.com/ipython/ipykernel/issues/795

thanks!

Contributor Guide