WordPress/gutenberg

Allow the PanelColorSettings to be visible if no colors and but with children

Open

#12.583 geöffnet am 4. Dez. 2018

Auf GitHub ansehen
 (6 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (9.607 Stars) (3.893 Forks)batch import
Good First IssueNeeds Dev[Package] Components[Type] Enhancement

Beschreibung

Is your feature request related to a problem? Please describe. With the PanelColorSettings, if the color prop is empty, the entire panel stops rendering. However, if PanelColorSettings has children, they won't show anymore also if the color prop is empty. I expect that the panel would still show up if it has children even with no color options available.

Describe the solution you'd like The PanelColorSettings should only hide if there are no color options AND no children. Right now is only checks the number of color options.

Describe alternatives you've considered I tried creating my own PanelColorSettings component to address this, but it uses a lot of unexposed / private components.

Contributor Guide

Tech Stack
javascriptreact
Domain
frontend
Issue Type
feature
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
2
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
fresh
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
ReactJavaScriptWordPress/Gutenberg basics
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
80
Research-Richtung
Locate the PanelColorSettings component in the Gutenberg repository, likely in packages/components/src. Examine the component's render method where it currently returns null if there are no color settings. Modify the conditional to also check for the presence of children (props.children) and render the component if children exist, even if color settings are empty. Test the change by setting the colors prop to empty but passing children to ensure they render.