ProjectEvergreen/greenwood

<script> tags using optimization attributes have a space before the closing bracket of the opening tag

Offen

#1.052 geöffnet am 05.02.2023

 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (15 Forks)auto 404
CLIenhancementgood first issue

Repository-Metriken

Stars
 (132 Sterne)
PR-Merge-Metriken
 (Durchschn. Merge 25T 20h) (29 gemergte PRs in 30 T)

Beschreibung

Type of Change

Enhancement / Bug / Other

Summary

If you notice in the source of the Greenwood website, the Apollo data and the webcomponents loader have a space before the closing bracket ( >) of the opening tag.

<script data-state="apollo" >
  window.__APOLLO_STATE__ = true;
</script>

  <!-- ... -->

  <script >
    /* ... */
  </script>

Details

It seems related to how these optimization attributes are being removed from the HTML during the optimization step as both of these leverage those custom attributes.

Probably good to make sure this isn't happening for <link> tags too.


Not a big deal but something worth looking into.

Contributor Guide