Microsoft/TypeScript

[type bug] fontfaces property is missing from loadingdone event object

Open

#51.885 geöffnet am 14. Dez. 2022

Auf GitHub ansehen
 (0 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (6.726 Forks)batch import
BugDomain: lib.d.tsHelp Wanted

Repository-Metriken

Stars
 (48.455 Stars)
PR-Merge-Metriken
 (Durchschn. Merge 6T 17h) (9 gemergte PRs in 30 T)

Beschreibung

Configuration Check

My compilation target is ES2015 and my lib is ES2022 & `DOM.

Missing / Incorrect Definition

Request to replace the event type of onloadingdone handler from Event to FontFaceSetLoadEvent, which has been defined in the same module.

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5530

https://github.com/microsoft/TypeScript/blob/eb9252ed9e53cd5f2732f14552a01920c4ec9401/lib/lib.dom.d.ts#L5548-L5550

Sample Code

interface FontFaceSet extends EventTarget {
-    onloadingdone: ((this: FontFaceSet, ev: Event) => any) | null;
+    onloadingdone: ((this: FontFaceSet, ev: FontFaceSetLoadEvent) => any) | null;
}

Documentation Link

https://w3c.github.io/csswg-drafts/css-font-loading/#FontFaceSet-events

Contributor Guide