Microsoft/TypeScript

Make private field name parsing ecma 262 compliant

Offen

#50.883 geöffnet am 21.09.2022

 (1 Kommentar) (1 Reaktion) (1 zugewiesene Person)TypeScript (13.395 Forks)batch import
BugDomain: ParserEffort: ModerateHelp WantedRescheduled

Repository-Metriken

Stars
 (108.860 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

This file has parse errors, but probably shouldn't.

Considerations:

  • https://github.com/microsoft/TypeScript/pull/50856 added support for starting with a unicode escape
  • The names #ZW__NJ and #ZW__J contain \u200c and \u200d, respectively (not here, but in the file)
  • Support for extended unicode escapes (i.e. \u{6F}, rather than \u006F) depends on ES2015, but we appear to parse the file as ES5.
  • Converting the extended unicode escapes to regular unicode escapes does not seem to eliminate the errors

Discovered as part of https://github.com/microsoft/TypeScript/issues/50835

Contributor Guide