Microsoft/TypeScript

simply logic predicate code fix or suggestion

Offen

#25.175 geöffnet am 23.06.2018

 (3 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (13.395 Forks)batch import
Domain: LS: RefactoringsHelp WantedSuggestion

Repository-Metriken

Stars
 (108.860 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

Search Terms

logic, predicate, quickfix

Suggestion

provide a code fix or refactor to simply logic predicate

Use Cases

simply some complexity logic predicate is hard and always get a break change, hope have a code fix to simply that like the jetbrain idea

Examples


if (! a && !b || !a && !c) {
    // something
}

fix to:

if (!(a && (b || c))) {
    // something
}

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript / JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. new expression-level syntax)

Contributor Guide