Knockout-Contrib/Knockout-Validation

Validation on nested objects not working after changing whole object

Open

#398 geöffnet am 28. Jan. 2014

Auf GitHub ansehen
 (2 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)JavaScript (1.024 Stars) (394 Forks)batch import
help wanted

Beschreibung

Hi, I have a problem with validating nested objects. I have following view model:

      var ViewModel = function (first) {
           this.person = ko.observable(new Person(first));

           this.changePerson = function () {
               this.person(new Person("changed"));
           };
      };

      var Person = function (first) {
           this.firstName = ko.observable(first).extend({
                required: true
           });
      };

everything works as expected as long as I do not call changePerson function. After calling change if I have element with data-bind="person().firstName" validation messages will not show. Working example (http://jsfiddle.net/MDhUR/). I found a work round to this issue - if I use to bind to firstName everything works as expected (http://jsfiddle.net/seRr5/1/) .

regards.

Contributor Guide

Tech Stack
javascript
Domain
frontend
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
half day
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
stale
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Knockout.js basics
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
60
Research-Richtung
The issue is that when replacing an observable containing a nested object, validation rules on the nested properties are not re evaluated. Look at the ko.validation plugin's initialization and how it subscribes to observables. Check if the validation is tied to the observable instance rather than its value. A possible fix involves ensuring validation is re applied when the observable value changes to a new object. Review the two JSFiddle examples provided to understand the working vs. non working scenarios. The relevant code is likely in the plugin's subscription logic for nested validation.