HabitRPG/habitica

Removing user from party does not prompt a check on whether a pending quest can start

Open

#11.566 geöffnet am 22. Nov. 2019

Auf GitHub ansehen
 (4 Kommentare) (0 Reaktionen) (1 zugewiesene Person)JavaScript (10.775 Stars) (3.912 Forks)batch import
help wantedpriority: minorsection: Party Page

Beschreibung

Jorayaho @Jorayaho (ab9c48bb-6b86-48dc-b3da-4fd0bac6a89c) [web] Hi, I just encountered an issue with a quest. 3 out of 4 party members accepted the quest invitation. I kicked the one who didn't accept. Quest didn't force-start (maybe the check if force-start is needed is only executed when a member accepts/declines) and when I started it manually it said not all party members accepted, only 3 out of 3.

Not yet tested; if anyone does have the chance to test this and confirm, that would be appreciated.

Contributor Guide

Tech Stack
javascriptnodejsmongodb
Domain
backend
Issue Type
bug
SchwierigkeitGeschätzte Implementierungsschwierigkeit für neue Contributors, von 1 für sehr kleine Änderungen bis 5 für Expertenarbeit.
3
Geschätzte ZeitEin grober Zeitrahmen, um zu recherchieren, zu implementieren, zu testen und einen Pull Request vorzubereiten.
1-3 hours
AktivitätsstatusWie verfügbar das Issue gerade wirkt: frisch, aktiv, stale, blockiert oder wartet auf Maintainer-Input.
blocked
KlarheitWie klar das Issue die erwartete Änderung, Akzeptanzkriterien und den nächsten Schritt erklärt.
clear
Voraussetzungen
Node.jsMongoDBknowledge of Habitica's quest system
EinsteigerfreundlichkeitEin Score von 1 bis 100, der schätzt, wie zugänglich dieses Issue für First-Time Contributors ist.
35
Research-Richtung
Investigate the quest start logic in the party model. Look at the function that triggers quest start upon member acceptance/decline. Check if there is a similar trigger when a member is removed. Examine files such as 'models/party' or 'controllers/quest' to understand the flow. Consider adding a check after removal to see if all remaining members have accepted and if the quest can start.