Glavin001/tslint-clean-code

Use Array.prototype.find() instead of .filter()[0]

Open

#56 geöffnet am 11. Juli 2018

Auf GitHub ansehen
 (1 Kommentar) (0 Reaktionen) (0 zugewiesene Personen)TypeScript (15 Forks)github user discovery
good first issuehelp wanted

Repository-Metriken

Stars
 (175 Stars)
PR-Merge-Metriken
 (Keine gemergten PRs in 30 T)

Beschreibung

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/find

const items = [
  { id: 123 },
  { id: 456 }
  // ...
];
const selectedId = 456;
const selectedItem = items.filter(item => item.id === selectedIds)[0];

Should be:

// ...
const selectedItem = items.find(item => item.id === selectedIds);

Diff:

- const selectedItem = items.filter((item) => item.id === selectedIds)[0];
+ const selectedItem = items.find((item) => item.id === selectedIds);

Contributor Guide