FEniCS/dolfinx

Using exception subtypes

Offen

#2.398 geöffnet am 07.10.2022

 (2 Kommentare) (0 Reaktionen) (0 zugewiesene Personen)C++ (255 Forks)auto 404
enhancementgood first issuehousekeeping

Repository-Metriken

Stars
 (1.158 Sterne)
PR-Merge-Metriken
 (PR-Metriken ausstehend)

Beschreibung

SonarCloud complains about our exception throwing, and I think it makes sense:

If you throw a general exception type, such as std::exception, std::logic_error or std::runtime_error, it forces consumers to catch all exceptions, including unknown exceptions they don’t necessarily know how to handle.

Instead, either throw a subtype that already exists ( for example in ), or create your own type that derives from a standard one.

https://wiki.sei.cmu.edu/confluence/display/java/ERR07-J.+Do+not+throw+RuntimeException%2C+Exception%2C+or+Throwable

Contributor Guide