Migrate legacy activities to the activity actor system
#40.013 geöffnet am 29. Apr. 2020
Repository-Metriken
- Stars
- (9.264 Stars)
- PR-Merge-Metriken
- (Durchschn. Merge 6T 5h) (292 gemergte PRs in 30 T)
Beschreibung
We have a new system for creating activities that is more robust and flexible that the previous one. However, most activities still use use the old system. It would be good if we could migrate these legacy activities to the new system, as the resulting code is easier to read, understand, and maintain.
For reference, the initial PR implementing the system is #37450 and a few example PRs migrating an activity to the new system are #39297 and #39646. Documentation for the activity actor system can be found here: doc/PLAYER_ACTIVITY.md. The activity handlers needing migration can be found in src/activity_handling.cpp.
If you'd like to help with this and have questions, feel free to hit me up on IRC or the development discord or just ping me for a pull request review.