Add option to enable auto-upgrade on Linux/Unix despite CAP_NET_BIND_SERVICE capability
#1.944 geöffnet am 25. Juli 2020
Repository-Metriken
- Stars
- (34.000 Stars)
- PR-Merge-Metriken
- (Keine gemergten PRs in 30 T)
Beschreibung
Problem Description
The if statement linked below rightly describes the issue with setting CAP_NET_BIND_SERVICE on binary files in Linux but doesn't account for setting this option using systemd's AmbientCapabilities directive instead, which doesn't require setting the capability on the binary itself.
Proposed Solution
Modify the if statement logic to allow users to override the behavior, perhaps with a command line flag like --allow-auto-update? When combined with the AmbientCapabilities systemd directive, this would allow users to auto upgrade the binary even when running AdGuardHome without root permissions.
Systemd Service File Example
AmbientCapabilities=CAP_NET_BIND_SERVICE
Alternatives Considered
Script the upgrade myself or fork the code, but a native solution would be much easier and a benefit for other Linux users. Thanks for the great application!