db-migrate/node-db-migrate

No order is guaranteed if migrations have the same date

Open

#646 opened on Aug 28, 2019

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (367 forks)batch import
bugfeaturegood first issuehelp wanted

Repository metrics

Stars
 (2,296 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm submitting a...

  • Bug report
  • Feature request
  • Question

Current behavior

Migrations on the same date (i.e. same year, month, day, hour, minute and second) aren't applied with any discernible criteria:

image

Expected behavior

I would expect the alphabetical order to be respected.

Minimal reproduction of the problem with instructions

create a bunch of migrations (if you have a machine fast enough to create multiple migrations on the same second, otherwise simply rename them)

for i in `seq 1 100`; do npx db_migrate create x$i --sql-file --env dev; done

apply them:

npx db_migrate up --env dev

watch them be in a randomish order

What is the motivation / use case for changing the behavior?

Avoid the confusion of users and breakage when auto-generating migrations

Environment

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Research direction
Modify the migration sorting logic to apply alphabetical order as a secondary sort criterion when dates are equal.
Tech stack
javascript
Domain
database
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75