db-migrate/node-db-migrate

Cannot migrate stored procedure

Open

#625 opened on May 24, 2019

View on GitHub
 (13 comments) (2 reactions) (0 assignees)JavaScript (2,296 stars) (367 forks)batch import
Upstreamfeaturehelp wanted

Description

I'm submitting a...

  • Bug report
  • Feature request
  • Question

Current behavior

When created a stored procedure it's necessary to change the delimiter e.g. DELIMITER $$

However, when using a SQL-file it returns ER_PARSE_ERROR:

Expected behavior

Be able to change the delimiter, create the SP and return delimiter back to standard ;

Minimal reproduction of the problem with instructions

DELIMITER // CREATE PROCEDURE testProc() BEGIN SELECT 1; END // DELIMITER ;

What is the motivation / use case for changing the behavior?

Cannot create or migrate stored procedures

Environment

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
javascriptnodejssqlmysql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic MySQL stored procedure syntaxfamiliarity with db migrate
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how db migrate mysql parses SQL files, focusing on the handling of DELIMITER statements. The issue likely resides in the SQL splitter or migration runner that currently treats DELIMITER as a regular SQL statement causing parse errors. Examine the source code in 'lib/db migrate mysql.js' or similar files, and consider implementing a preprocessing step to handle delimiter changes before passing SQL to the MySQL driver. Review the existing comments for any proposed solutions or workarounds.