db-migrate/node-db-migrate

EventEmitter memory leaks

Open

#421 opened on Oct 4, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (367 forks)batch import
Refactoringgood first issuehelp wanted

Repository metrics

Stars
 (2,296 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

When using db-migrate programmatically for multiple databases, warnings are generated for EventEmitter leaks: Warning: Possible EventEmitter memory leak detected. 11 unhandledRejection listeners added.

Adding a unregisterEvents function to api.js should enable programmatic users to get around this. Such a function may also be used more generally to do proper cleanup.

Where registerEvent() is called: https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L136-L147

Where registerEvents() is defined: https://github.com/db-migrate/node-db-migrate/blob/master/api.js#L136-L147

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Research direction
Look at the registerEvents function in api.js, understand how events are added, and implement an unregisterEvents function to remove the listeners for cleanup.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75