db-migrate/node-db-migrate

Support "databaseless" execution commands

Open

#338 opened on Jan 17, 2016

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (2,296 stars) (367 forks)batch import
featuregood first issuehelp wanted

Description

Current behavior

When a driver initiates a connection it gets passed the config and uses this straightforward. This creates a problem as soon as commands like db:create and db:drop are about to be executed. Those have no need to be actually be connected to a database directly and this in turn might result in issues while connecting to this database which may not exists already.

Proposed solution

On commands that can omit the database parameter those are going to be stripped away by db-migrate before they actually reach the driver. The drivers in turn have to assure that they handle the default behavior correctly. There are for example open items for postgres https://github.com/db-migrate/pg/issues/5.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Tech stack
javascriptnodejssqlpostgresql
Domain
database
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js experienceDatabase migration conceptsdb migrate driver architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the current command execution flow in db migrate, particularly the `db:create` and `db:drop` commands. Identify where the database parameter is passed to drivers. Propose a mechanism to strip the database parameter for these commands before invocation. Also review the open issue in the postgres driver (https://github.com/db migrate/pg/issues/5) to ensure compatibility. Consider adding a flag or method in the driver interface to indicate databaseless support.