davidtheclark/react-aria-menubutton

Select number value when a user begins typing while the dropdown is open

Open

#79 opened on Apr 5, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (85 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (456 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

While this library is fantastic for words, when dropdown has numbers as the dropdown values and the user types a number value to search for it, the dropdown does not highlight that number.

e.g. in a dropdown list of birth years [2004... 1932], when the dropdown is open and the user types "1984", that value is not highlighted.

The reason for this may be addressed elsewhere, but wanted to file an issue to ask for clarification on this.

Contributor guide

Research direction
Look at the filtering logic for typeahead in the dropdown. Check if the issue is due to type coercion or case sensitivity when comparing typed numbers with option values.
Tech stack
javascriptreact
Domain
frontendaccessibility
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75