davidtheclark/no-scroll

Previous styles on documentElement are not restored

Open

#10 opened on Jan 2, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (13 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (244 stars)
PR merge metrics
 (PR metrics pending)

Description

I had a use case where the documentElement had inline styles on it, like so: <html style="padding: 0; margin: 0; overflow-x=hidden;">. I noticed that after toggling no-scroll to off, the overflow-x=hidden was being wiped out. After checking the code in no-scroll, I found that it's hard-coding the style attributes when off() is called. I think that no-scroll should be restoring whatever values were set before on() was called, instead of overwriting them.

Contributor guide

Research direction
Inspect the source code of the off() function; it currently overwrites documentElement style attributes. Modify on() to store the original style attribute values and off() to restore them.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80