davideas/FlexibleAdapter

Long click not recognized on Galaxy S8/S9 only if drag view with long click is enabled

Open

#676 opened on Oct 5, 2018

View on GitHub
 (9 comments) (2 reactions) (0 assignees)Java (3,534 stars) (553 forks)batch import
bughelp wanted

Description

I have been debugging this behavior for some days and I am finally at the conclusion that the bug is highly likely not to be in my code base:
I don't get any OnLongClick callbacks on the Galaxy S8 (probably S9, too). You can reproduce this behavior by running the FlexibleAdapter-demo app, once on an S8, once on any other phone.

  1. Open the example "headers and sections"
  2. Long click on the first item ---> on the S8 there is no "long click on xxx" toast shown, on any other phone, the toast is shown

Since the Galaxy phones represent a big part of the phone market, this is a big problem for us (and therefore for many other users of the library I suppose). It destroys one of our features and I cannot find any way to fix it. I am thankful for any advice!

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android developmentRecyclerViewTouch event handlingDevice specific testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the OnLongClick callback in the FlexibleAdapter library, focusing on touch event handling and the interaction with drag view long click. Reproduce the behavior on Galaxy S8/9 emulators or devices. Check the issue comments for any additional findings. Look at the source code in the repository, particularly files related to touch and click handling.