dateutil/dateutil

tzfile reader only reads 32-bit (verson 0) zoneinfo files

Open

#462 opened on Sep 20, 2017

View on GitHubContributor guide
 (4 comments) (4 reactions) (0 assignees)Python (470 forks)batch import
bugenhancementhelp wantedmedium-difficultytime zones

Repository metrics

Stars
 (2,189 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The output of zic includes a 32-bit legacy section and a 64-bit section that encodes the transition times as 64-bit epoch times. Currently we're only reading the first one. What we should do is read the zoneinfo header to determine how long the first section is, seek to the end of that section and see if there's a second "version 2" section, and if so read that one instead, otherwise go back and finish reading the 32-bit version.

This will have almost no real effect at the moment.

Contributor guide

Research direction
Inspect the tzfile reader to understand the current 32 bit reading, then add logic to read the header, check for version 2, and seek to the 64 bit section if present.
Tech stack
python
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60