Remove usage of strlen, memcpy and malloc

Open
#262 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
objective-c, swift
Domain
mobile-dev, security

Research direction

The issue names registry_search, RSSwizzle, and trie_search as the relevant entry points; inspect those implementations for strlen, memcpy, and malloc usage and check how TrustKit builds on Xcode 12.5. Done means each use is removed or its necessity is documented with the security rationale.

Written by the indexing model from the issue text.

Description

Environment
Xcode version: 12.5
TrustKit Pod version: 1.7.0
Language: Swift

Issue:
We are using the trustKit for SSL Pinning in our application.
Our penetration testing team have found out that some insecure source code functions are being used in the application(strlen, memcpy and malloc) which is from the Trustkit library's below functions:
registry_search
RSSwizzle
trie_search

Could you remove these from the Trustkit library in your upcoming release or if it is required, could you let us know why it is required?

Dominant language
Objective-C
Stars
2.1k
Forks
381
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from datatheorem/TrustKit

All issues in datatheorem/TrustKit

Similar issues

More Objective-C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.