BOH - broken link to function source

Open Beginner friendly
#18 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
html, powershell
Domain
documentation

Research direction

Open boh.html around line 208 and inspect how the BOH source link is assembled. Update the outdated functions path to the public path shown in the issue, then verify the Remove-DbaDatabaseSafely link resolves to the dbatools source file.

Written by the indexing model from the issue text.

Description

Consider https://dataplat.github.io/boh#Remove-DbaDatabaseSafely

BOH page showing outgoing link in tooltip

Note that currently the link to the source code is of the format ...blob/development/functions/...

The /functions/ folder structure was changed in https://github.com/dataplat/dbatools/pull/8737 - the BOH links need updating to the new format.

AFAICT, the necessary change should go here: https://github.com/dataplat/dataplat.github.io/blob/2e992be95fb4ad445892f21e8be56629cc7a972e/boh.html#L208

- return '<a target="_blank" href="https://github.com/dataplat/dbatools/blob/' + activebranch + '/functions/' + data + '.ps1">' + data + '</a>'
+ return '<a target="_blank" href="https://github.com/dataplat/dbatools/blob/' + activebranch + '/public/' + data + '.ps1">' + data + '</a>'
Dominant language
HTML
Stars
12
Forks
8
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.