Migrate to `System.Text.Json`

Open
#125 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
api

Research direction

Start by reviewing the SeqTail sample and locating the Newtonsoft dependency in seq-api. Check the proposed Serilog.Formatting.Compact.Reader substitution and the related issue #22, then establish the migration scope and existing test coverage. Done means an agreed scope and a reviewed change with the relevant tests passing.

Written by the indexing model from the issue text.

Description

enhancement

Do you plan to remove it in favor of System.Text.Json?

I've tried to do this and i got a (working?) result in a couple of hours... if it's appreciated and/or if you want ro review it i could do a PR ...

Doing this work, while doing some tests with the SeqTail sample) I've also found a dependency to Newtonsoft coming from Serilog.Formatting.Compact.Reader... so I substituted it also in that project... (i've also seen https://github.com/serilog/serilog-formatting-compact-reader/issues/22 ). In this case there are a lot of test and all them are passing. So i could make a PR also for this: let me know...

Dominant language
C#
Stars
86
Forks
23
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from datalust/seq-api

All issues in datalust/seq-api

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.