[coverage] Conformance findings: STATEMENT-023

Open
#480 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
sql, typescript
Domain
api, backend, databases

Research direction

Start with the STATEMENT-023 — driver bug: failing teardown CloseOperation escapes dispose [thrift] [xfail] test in the coverage PR's tests/ diff, then reproduce it with the two SQL statements in this issue. Trace result-reader disposal through the Thrift CloseOperation and verify completion without an exception, one returned row, blocked reads after disposal, and the expected cleanup call.

Written by the indexing model from the issue text.

Description

Summary

Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-nodejs. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-nodejs) is fixed, then flips green as a tripwire.

Findings

  • STATEMENT-023 [thrift]: Thrift op.close() rethrows a failed teardown CloseOperation (injected 404) out of dispose instead of treating the per-operation close as best effort, so a cleanup-only error surfaces to the caller after results are fully consumed and the rest of the reader teardown is skipped
    • failing test: STATEMENT-023 — driver bug: failing teardown CloseOperation escapes dispose [thrift] [xfail] (see the coverage PR diff under tests/)

Reproduce & Expected

STATEMENT-023 — The per-operation close RPC (Thrift CloseOperation / SEA CloseStatement) issued during result-reader disposal is TEARDOWN cleanup: the operation's results have already been consumed by the time dispo…

Reproduce:

SELECT id FROM range(10000)
SELECT 1 AS test_value

Expected (per the shared spec):

  • completes without an exception
  • result has exactly 1 row(s)
  • full assertion contract:
result:
- no_exception: true
- reads_blocked_after_dispose: true
- result_not_null: true
- row_count: 1
protocol:
  thrift:
  - call_min:
      method: CloseOperation
      min: 1
  sea:
  - call_min:
      operation: CloseStatement
      min: 1

Context

Dominant language
TypeScript
Stars
36
Forks
50
Avg merge
13h 46m
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from databricks/databricks-sql-nodejs

All issues in databricks/databricks-sql-nodejs

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.