Incomplete tests

Open
#301 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Quiet
Tech stack
python
Domain
testing

Research direction

Choose one unchecked item rather than taking on this entire tracking issue, then read the named test file and its TODO or linked issue. Run the relevant existing test module to understand its current coverage. Done means the selected gap is covered and the corresponding test passes.

Written by the indexing model from the issue text.

Description

high priority

This is a tracking issue for tests that are currently incomplete. These are mostly notated in the code by TODO comments, but it's useful to note them all here too. I haven't checked everything throughly so if there is something missing that isn't noted in a comment it might not be listed here.

Note there are also some functions that aren't yet tested at all, but those are covered in separate issues (e.g., #248 #299). I also am not including tests that are currently skipped entirely as flaky (https://github.com/data-apis/array-api-tests/issues/300).

test_array_object.py

  • test_getitem_masking.py (key.ndim < x.ndim not tested)

test_creation_functions.py

The device keyword is never tested (see below)

test_data_type_functions.py

  • test_astype (no complex types, no values testing, no test for copy) -- gh-311
  • test_broadcast_arrays (no values testing)
  • test_broadcast_to (no values testing)
  • test_can_cast (no complex types) -- https://github.com/data-apis/array-api-tests/pull/320
  • test_finfo (no values testing)
  • test_iinfo (no values testing)

test_fft.py

test_has_names.py

test_indexing.py

test_inspection_functions.py

Basically none of the inspection APIs are currently tested, beyond the basic signature tests. Note that for many of these functions, we may not even need to use hypothesis. Just a basic test that the function outputs the right thing and a smoke test that the data outputted is correct.

test_linalg.py

(note: values testing here might be hard. Values testing isn't as high priority for functions that already generally work)

  • test_det (no values testing)
  • test_eigh (no values testing)
  • test_eigvalsh (no values testing)
  • test_eig (no values testing)
  • test_eigvals (no values testing)
  • test_inv (no values testing)
  • test_matmul (the @ __matmul__ operator methods are not tested)
  • test_matrix_norm (no values testing)
  • test_qr (no test that Q is orthonormal)
  • test_slogdet (no values testing)
  • test_svdvals (no values testing; no test that it agrees with svd())
  • test_trace (need to update dtype assertion, this should match test_sum)
  • test_vector_norm (no values testing)

Additionally, there are some limitations in the hypothesis strategies used by some of the functions. These should be made more general so that the functions are actually tested on a full gamut of possible inputs:

  • symmetric_matrices (does not generate complex Hermitian matrices
  • positive_definite_matrices (only generates stacks of identity matrices
  • invertable_matrices (only generates stacks of diagonal matrices)

test_manipulation_functions.py

test_operators_and_elementwise_functions.py

  • test_divide (no complex numbers testing) -- fixed in gh-306
  • test_negative (there is a TODO about uints)
  • scalar support in binary functions: (better value testing, test complex dtypes); tracked in https://github.com/data-apis/array-api-tests/issues/364
  • test_clip : no testing of an int scalar min/max and a float array

test_signatures.py

Several issues tracked in other issues: https://github.com/data-apis/array-api-tests/issues/256, https://github.com/data-apis/array-api-tests/issues/171

test_sorting_functions.py

  • test_argsort (no testing of signed zeros or nans)
  • test_sort (no testing of signed zeros or nans)

test_special_cases.py

Many special cases are not tested. This is tracked at https://github.com/data-apis/array-api-tests/issues/284

test_statistical_functions.py

See also https://github.com/data-apis/array-api-tests/issues/167

  • test_mean (no values testing)
  • test_std (no values testing)
  • test_var (no values testing)

test_utility_functions.py

  • test_diff (no values testing for n > 1)

OTHER

Dominant language
Python
Stars
74
Forks
54
Avg merge
4d 15h
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from data-apis/array-api-tests

All issues in data-apis/array-api-tests

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.