has_names test can't run if certain names are missing

Open
#223 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing-qa

Research direction

Start with array_api_tests/dtype_helpers.py around the all_dtypes definition, and trace how the has-names test is loaded through conftest.py and reporting.py. Run the test with a module missing bool; done means the test can load and check available names without failing during dtype helper import.

Written by the indexing model from the issue text.

Description

The has names test should run regardless of what names are present in the module. Right now, it fails if bool is not present

ImportError while loading conftest '/Users/aaronmeurer/Documents/array-api-tests/conftest.py'.
conftest.py:13: in <module>
    from reporting import pytest_metadata, pytest_json_modifyreport, add_extra_json_metadata # noqa
reporting.py:1: in <module>
    from array_api_tests.dtype_helpers import dtype_to_name
array_api_tests/dtype_helpers.py:138: in <module>
    all_dtypes = (xp.bool,) + numeric_dtypes
E   AttributeError: module 'mlx.core' has no attribute 'bool'
Dominant language
Python
Stars
74
Forks
54
Avg merge
4d 15h
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from data-apis/array-api-tests

All issues in data-apis/array-api-tests

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.