signature tests being misled by **kwargs
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 42/100
Research direction
Start in array_api_tests/test_signatures.py around line 92, where the meshgrid signature is checked. Run the relevant signature test and compare its handling of explicit parameters with **kwargs; done means cupy.meshgrid's indexing keyword is not rejected solely because its signature exposes kwargs.
Written by the indexing model from the issue text.
Description
The meshgrid signature test fails with cupy:
E AssertionError: Argument 'indexing' missing from signature
E assert 'indexing' in odict_keys(['xi', 'kwargs'])
E + where 'indexing' = <Parameter "indexing: str = 'xy'">.name
E + and odict_keys(['xi', 'kwargs']) = <built-in method keys of mappingproxy object at 0x7fc946212170>()
E + where <built-in method keys of mappingproxy object at 0x7fc946212170> = mappingproxy(OrderedDict([('xi', <Parameter "*xi">), ('kwargs', <Parameter "**kwargs">)])).keys
E + where mappingproxy(OrderedDict([('xi', <Parameter "*xi">), ('kwargs', <Parameter "**kwargs">)])) = <Signature (*xi, **kwargs)>.parameters
array_api_tests/test_signatures.py:92: AssertionError
cupy.meshgrid does have the indexing keyword, but its signature is meshgrid(*x, **kwargs). If we can't check a keyword argument directly, we should assume it is present with **kwargs, and let the individual tests suss out whether it really supports it.
- Dominant language
- Python
- Stars
- 74
- Forks
- 54
- Avg merge
- 4h 35m
- Merged PRs (30d)
- 4
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from data-apis/array-api-tests
-
Difficulty 2/5 1-3 hours Newbie friendliness 87/100
data-apis/array-api-tests#465 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
data-apis/array-api-tests#460 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
data-apis/array-api-tests#455 · 2 comments ·
-
tracking
Difficulty 5/5 Over a week Newbie friendliness 25/100
data-apis/array-api-tests#381 · 9 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 38/100
data-apis/array-api-tests#379 · 10 comments ·
All issues in data-apis/array-api-tests
Similar issues
-
bug confirmed issue
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
open-webui/open-webui#30750 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
good first issue
Difficulty 1/5 Under an hour Newbie friendliness 90/100