darxtrix/ptop

Use a good logging mechanism

Open

#21 opened on Jul 12, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (43 forks)batch import
good first issuerefactoring

Repository metrics

Stars
 (573 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am not able to see the logs in the .ptop.log file.

A better way would be make a directory named .ptop and add separate log files under it. For the sake of preventing memory flooding, we have to have some cycling/cleaning mechanism of log files.

Need to see what are the best practices for usage of logging module.

Observations

  • Current behavior is that only INFO level logs are made to the log file and upon termination/quitting of ptop the log file is erased.

Contributor guide

Research direction
Research Python logging best practices, implement a rotating file handler in a .ptop directory, and ensure logs persist after application exit.
Tech stack
python
Domain
cli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70