git commands not running on Windows
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 62/100
Research direction
Start in script_manager.lua at get_current_repo_branch around line 318 and trace the Lua scripts that invoke git through io.popen. Test a repository path containing spaces on Windows and verify that git status and the other affected commands resolve the repository correctly without changing directories.
Written by the indexing model from the issue text.
Description
On windows executing the git command fails from the lua scripts.
It might have something to do with my repo path containing a space. Thought just putting quotes around it does not fix it, there might be strange behaviour in combination with the & concatenator as well.
io.popen("cd " .. repo .. CS .. "git status")
->
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
8,8792 LUA ERROR: script_manager.lua: get_current_repo_branch: 318: no current branch detected in repo_data
In my opinion a better solution would be to use the -C <path> argument of git for all commands instead of changing the directory, and also quoting the repo string:
io.popen("git -C \"" .. repo .. "\" status")
- Dominant language
- Lua
- Stars
- 219
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from darktable-org/lua-scripts
-
dtutils.string: build_substitute_list errors when a metadata field (e.g. rights) has been removed Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
darktable-org/lua-scripts#716 · 2 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
darktable-org/lua-scripts#706 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
darktable-org/lua-scripts#627 · 2 comments ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 65/100
darktable-org/lua-scripts#618 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
darktable-org/lua-scripts#710 · 3 comments ·
All issues in darktable-org/lua-scripts
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
api7/lua-resty-saml#62 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nvim-tree/nvim-tree.lua#3357 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
codymikol/multiverse.nvim#320 ·
-
Data Correction tbc
Difficulty 2/5 1-3 hours Newbie friendliness 68/100