Merge clear_GPS.lua and reset_GPS.lua into geoToolbox.lua

Open
#268 30 comments 0 reactions 1 assignee View on GitHub

@wpferguson is already working on this.

Since Aug 2, 2020.

Assessment

This issue has not been assessed yet.

Description

dt5.4

When I submitted a PR to add reset_GPS.lua @supertobi noted that it might be a good fit in geoToolbox.lua. I had just read through the geoToolbox.lua code and thought the same thing, so I closed the PR and decided to merge the code. clear_GPS.lua also manipulates image GPS information so that is also probably a good fit in geoToolbox.lua.

I opened this issue so that there would be a place to discuss the merge and how to arrive at a best fit.

Dominant language
Lua
Stars
219
Forks
142
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from darktable-org/lua-scripts

All issues in darktable-org/lua-scripts

Similar issues

More Lua issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.