dareid/chakram

Invalid validation keywords and types

Open

#27 opened on Nov 26, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (907 stars) (100 forks)batch import
enhancementhelp wanted

Description

    it("should list all avilable players", function () {
        var responseStructure = {
            type: "array",
            properties:{
                enabled : {type:"string"},  //This is expected to be an integer, but test passes
                defaultLanguage :{type:"integer"},
                defaultCurrency :{type:"integer"},
                lastname :{type:"string"},
                firstname:{type:"string"},
                passwordSalt:{type:"string"},
                password:{type:"string"},
                email:{type:"string"},
                id:{type:"string"} //Also this, expected to be an integer, but it passes the test
            }
        }
        var response = chakram.get(endpoint);
        return expect(response).to.have.schema(playerDataStructure);

I observed that the properties are not checked even when the properties expected doesn't match the types in the reponse, the test still passes.

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of JSON schema validationFamiliarity with chakram's test structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the schema validation logic in chakram's source code, likely in `lib/schema.js` or similar. The issue describes that properties are not being validated against their types. Look for where `type` and `properties` are checked, and ensure that the validator correctly enforces type constraints. Also check the existing test suite for schema validation to see if there are tests that pass incorrectly. The issue is old (2015), so the code may have changed; verify if the bug still exists in the current version.